Skip to content

Conversation

sjbronner
Copy link

The previous behavior would unquote any %-encoded characters in hrefs, including slashes, and then re-encode them, excluding slashes. This caused a fatal error when the href contained quoted slashes. The final href with the originally quoted slashes now unquoted, would not exist and prevent an entire calendar from syncing completely.

It looks to me like the unquote step is only there to avoid re-quoting already quoted characters. In order to avoid leaving quoted slashes unuoted, I have removed the unquote step and added the % symbol to the list of characters to leave unquoted when quoting the href.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant